[PATCH] D93983: RegAllocFast: Do not free later early-clobbered registers.

Freddy, Ye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 07:39:26 PST 2021


FreddyYe marked an inline comment as done.
FreddyYe added a comment.

THX for review!



================
Comment at: llvm/test/CodeGen/X86/corner-msInline-fastregalloc.mir:5-24
+
+--- |
+  ; ModuleID = 'llvm/test/CodeGen/X86/phys-msInline-fastregalloc.ll'
+  source_filename = "llvm/test/CodeGen/X86/phys-msInline-fastregalloc.ll"
+  target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+  
+  define dso_local i32 @foo() {
----------------
arsenm wrote:
> You should be able to drop the whole IR section
I failed to drop the IR. Because if dropped, %stack.0.retval and %stack.1.c will parsed by llc as not defined. Maybe I'm doing the wrong way. I'm not so familiar with MIR. Can you show me an example also drops IR but with stack variable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93983/new/

https://reviews.llvm.org/D93983



More information about the llvm-commits mailing list