[PATCH] D93858: [obj2yaml,yaml2obj] - Refine how we set/dump the sh_entsize field.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 06:16:38 PST 2021


grimar added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/ELF/mips-abi-flags.yaml:54-55
 # MIPS-NEXT:   Type: SHT_MIPS_ABIFLAGS
+## We don't print the "EntSize" key, because 0x18 is the default value
+## for the sh_entsize field of SHT_MIPS_ABIFLAGS.
 # MIPS-NEXT:   ISA:  0x0
----------------
jhenderson wrote:
> Do you think this deserves a case where the entsize is not default?
Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93858/new/

https://reviews.llvm.org/D93858



More information about the llvm-commits mailing list