[PATCH] D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs

Praveen G via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 06:07:28 PST 2021


praveen added a comment.

In D92735#2492674 <https://reviews.llvm.org/D92735#2492674>, @sameeranjoshi wrote:

> In D92735#2490685 <https://reviews.llvm.org/D92735#2490685>, @praveen wrote:
>
>> In D92735#2488356 <https://reviews.llvm.org/D92735#2488356>, @kiranchandramohan wrote:
>>
>>> Need an answer here to proceed with review.
>>
>> @kiranchandramohan I am trying to resuse the function CheckBranchesIntoDoBody . Will update the patch regarding the same.
>>
>> @sameeranjoshi Will you be merging the related changes  https://reviews.llvm.org/D93447 that makes use of LabelEnforce ?
>
> I was waiting for action based on the approach we follow from the current patch.
> If all statements from `LabelEnforce` are allowed inside an openmp block, I can merge the pending patch?

@sameeranjoshi I do not see any restrictions on not allowing the statements part of  'LabelEnforce' inside the OpenMP block as per the OpenMP 4.5 documentation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92735/new/

https://reviews.llvm.org/D92735



More information about the llvm-commits mailing list