[PATCH] D94429: AMDGPU: Move handling of allocation of fixed ABI inputs

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 05:24:45 PST 2021


Flakebi added a comment.

> Also stop passing them for amdgpu_gfx, since the DAG path seems to skip these. I'm unclear on what amdgpu_gfx's expectations are.

As far as I understand, the “special inputs” are arguments relevant for HSA only and depending on `EnableFixedFunctionABI` they are added in the beginning or end of arguments.
So, `passSpecialInputs` should be guarded by “is HSA” instead of “is not amdgpu_gfx”?

I think we only want to pass the stack pointer into functions for our usage of amdgpu_gfx (and other implicit arguments like exec). All other arguments are added by the frontend.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94429/new/

https://reviews.llvm.org/D94429



More information about the llvm-commits mailing list