[PATCH] D93858: [obj2yaml,yaml2obj] - Refine how we set/dump the sh_entsize field.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 05:14:53 PST 2021


grimar added a comment.

In D93858#2478697 <https://reviews.llvm.org/D93858#2478697>, @jhenderson wrote:

> Could you explain why this patch fixes the ARM_EXIDX sh_entsize specifically? I don't see anything immediately that would only fix that section (and not other sections).

It's because `writeSectionContent(..., const ELFYAML::ARMIndexTableSection &Section, ...)` doesn't set the `EntSize` field as it supposed to. This patch
generalizes the logic, now we set this field in the single place, and so the issue was revealed (see `arm-exidx-section.yaml`).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93858/new/

https://reviews.llvm.org/D93858



More information about the llvm-commits mailing list