[PATCH] D94323: [dsymutil] Add preliminary support for DWARF 5.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinkerForBinary.cpp:774
+  if (It == ValidDebugAddrRelocs.end())
+    return Offset;
+  return It->Mapping->getValue().BinaryAddress;
----------------
It looks incorrect to return offset in debug_addr section as the value of relocated address. It might be better to make return value Expected and return Error in case offset is not found.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94323/new/

https://reviews.llvm.org/D94323