[PATCH] D92923: [llvm-readelf/obj] - Add support of multiple SHT_SYMTAB_SHNDX sections.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/include/llvm/Object/ELF.h:74
+      if (N >= *Size)
+        return createError("the index is greater than the number of entries (" +
+                           Twine(*Size) + ")");
----------------
jhenderson wrote:
> Maybe: "the index N is greater than..." (where N is the specified index)?
For the message below I report the index value on the caller side (see `getExtendedSymbolTableIndex`).
Probably worth to be consistent here.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/symtab-shndx.test:240
+
+# RUN: yaml2obj --docnum=2 -DSYMTABSHNDX=0x2000 %s -o %t.pastend
+# RUN: llvm-readelf --dyn-syms %t.pastend 2>&1 | \
----------------
jhenderson wrote:
> You only use the second docnum once. Can you get rid of the macro?
Yes, done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92923/new/

https://reviews.llvm.org/D92923