[PATCH] D89845: Add the ability to extract the unwind rows from DWARF Call Frame Information.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:85
+public:
+  UnwindLocation(const UnwindLocation &RHS) = default;
+  UnwindLocation &operator=(const UnwindLocation &RHS) = default;
----------------
The two lines can be dropped.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:171
+public:
+  RegisterLocations() = default;
+
----------------
This can be dropped.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:250
+public:
+  UnwindRow() : Address(None), CFAValue(UnwindLocation::createUnspecified()) {}
+
----------------
Delete `Address(None)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89845/new/

https://reviews.llvm.org/D89845