[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

Mon Jan 11 19:46:16 PST 2021

modimo added a comment.

In D94333#2491835 <https://reviews.llvm.org/D94333#2491835>, @mtrofin wrote:

> I wouldn't block this patch on that - we can do the refactoring subsequently.

Sounds good.

In D94333#2491836 <https://reviews.llvm.org/D94333#2491836>, @mtrofin wrote:

> LGTM; but so I understand something better: the ability to replay is somewhat 'best effort' if the compiler changes (or, of course, the compiled code). May be worth adding a comment about that?

Thanks for signing off! Your take here is correct, this is operating under a best effort approach to replay. In D94334 <https://reviews.llvm.org/D94334> I note that testing on mysqld the current solution for CGSCC inline replay is ~94% accurate in replaying when comparing remarks base vs. replay.

Added a comment in ReplayInlineAdvisor describing the best effort approach here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94333/new/

https://reviews.llvm.org/D94333