[PATCH] D94460: [dsymutil] Copy eh_frame content into the dSYM companion file.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/tools/dsymutil/MachOUtils.cpp:294-295
     auto Sect = getSection(Obj, Segment, LCI, i);
-    Sect.offset = Sect.reloff = Sect.nreloc = 0;
+    if (Sect.sectname == "eh_frame")
+      Sect.offset = Sect.reloff = EHFrameOffset;
+    else
----------------
friss wrote:
> Is `reloff` set to anything in the original file? I think it's supposed to be the offset to the list of relocations for the section, but `eh_frame` shouldn't have any relocations at this point. Anyway, I think it's better to force it to 0 as well as `nreloc`.
Yeah that was a typo (copy paste-o?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94460/new/

https://reviews.llvm.org/D94460