[PATCH] D94460: [dsymutil] Copy eh_frame content into the dSYM companion file.

[Frederic Riss via Phabricator via llvm-commits]

friss added a comment.

Couple comments/questions, but this generally looks good



================
Comment at: llvm/test/tools/dsymutil/X86/eh_frame.test:24
+CHECK: 14 00 00 00 00 00 00 00 01 7a 52 00 01 78 10 01
+CHECK: 10 0c 07 08 90 01 00 00
----------------
Can we add a check that the generated DWARF segment is well-formed?


================
Comment at: llvm/tools/dsymutil/MachOUtils.cpp:294-295
     auto Sect = getSection(Obj, Segment, LCI, i);
-    Sect.offset = Sect.reloff = Sect.nreloc = 0;
+    if (Sect.sectname == "eh_frame")
+      Sect.offset = Sect.reloff = EHFrameOffset;
+    else
----------------
Is `reloff` set to anything in the original file? I think it's supposed to be the offset to the list of relocations for the section, but `eh_frame` shouldn't have any relocations at this point. Anyway, I think it's better to force it to 0 as well as `nreloc`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94460/new/

https://reviews.llvm.org/D94460