[PATCH] D94460: [dsymutil] Copy eh_frame content into the dSYM companion file.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 17:01:38 PST 2021


aprantl added a comment.

I think this looks reasonable!



================
Comment at: llvm/test/tools/dsymutil/X86/eh_frame.test:2
+// FIXME: Replace otool with llvm-objcopy --dump-section=__TEXT,__eh_frame.
+// REQUIRES : system-darwin
+
----------------
This test has an odd combination of syntax :-)
Why C-style comments here ...


================
Comment at: llvm/test/tools/dsymutil/X86/eh_frame.test:19
+
+RUN: dsymutil -oso-prepend-path %p/../Inputs %p/../Inputs/private/tmp/eh_frame/eh_frame.out -o %t.dSYM
+RUN: otool -s __TEXT __eh_frame %p/../Inputs/private/tmp/eh_frame/eh_frame.out | FileCheck %s
----------------
... and not here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94460/new/

https://reviews.llvm.org/D94460



More information about the llvm-commits mailing list