[PATCH] D94316: [lld-macho] Associate each Symbol with an InputFile

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: lld/MachO/Symbols.h:201
+    assert(isa<DylibFile>(file));
+    return static_cast<DylibFile *>(file);
+  }
----------------
Why not just `cast<DylibFile>(file)`?  It will preserve the assertion and have the same behaviour.


================
Comment at: lld/MachO/Symbols.h:223
+    assert(isa<ArchiveFile>(file));
+    return static_cast<ArchiveFile *>(file);
+  }
----------------
Similar


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94316/new/

https://reviews.llvm.org/D94316