[PATCH] D90046: [LiveDebugValues] Handle spill locations with a fixed and scalable component.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp:574-576
+                   Other.Var, Other.Kind, Other.Loc.SpillLocation.SpillBase,
+                   Loc.SpillLocation.SpillOffset.getFixed(),
+                   Loc.SpillLocation.SpillOffset.getScalable(), Other.Expr);
----------------
StephenTozer wrote:
> The SpillOffset fixed and scalable arguments here are missing `Other.`, so we're comparing the current `VarLoc` to itself - can you fix this in a followup patch?
Good spot, thanks for pointing out! Do you have any objection for me to just push the fix directly? (I wouldn't really know how to create a test for this, unless you have any suggestions?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90046/new/

https://reviews.llvm.org/D90046