[PATCH] D94417: [ADT][Support] Disable C4146 MSVC warning

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 12:30:56 PST 2021


RKSimon added a reviewer: RKSimon.
RKSimon added a comment.

In D94417#2491085 <https://reviews.llvm.org/D94417#2491085>, @dblaikie wrote:

> Perhaps we could rewrite the code to use ~ or the like instead of unary - if that works?

+1 We currently globally disable C4146 inside llvm-project\llvm\cmake\modules\HandleLLVMOptions.cmake (along with a lot of other warnings that ideally we'd enable and make use of) - it'd be great if you could fix at least the code here instead of adding a lot of pragmas.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94417/new/

https://reviews.llvm.org/D94417



More information about the llvm-commits mailing list