[PATCH] D94341: [AMDGPU] Add _e64 suffix to VOP3 Insts

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash added a comment.

In D94341#2490208 <https://reviews.llvm.org/D94341#2490208>, @foad wrote:

> Looks OK to me. Does this enable any immediate simplifications? Or is it just to help with future work?

Just helps with future work. The idea is we can treat VOP3 Pseudos the same regardless of their origin.



================
Comment at: llvm/lib/Target/AMDGPU/VOP3Instructions.td:386-387
 let SchedRW = [WriteDoubleAdd], FPDPRounding = 1 in {
-def V_DIV_FIXUP_F64 : VOP3Inst <"v_div_fixup_f64", VOP3_Profile<VOP_F64_F64_F64_F64>, AMDGPUdiv_fixup>;
-def V_LDEXP_F64 : VOP3Inst <"v_ldexp_f64", VOP3_Profile<VOP_F64_F64_I32>, AMDGPUldexp, 1>;
+defm V_DIV_FIXUP_F64 : VOP3Inst <"v_div_fixup_f64", VOP3_Profile<VOP_F64_F64_F64_F64>, AMDGPUdiv_fixup>;
+defm V_LDEXP_F64 : VOP3Inst <"v_ldexp_f64", VOP3_Profile<VOP_F64_F64_I32>, AMDGPUldexp, 1>;
 } // End SchedRW = [WriteDoubleAdd], FPDPRounding = 1
----------------
foad wrote:
> Indent?
The indentation is not very consistent in this file, but I added one here, and a few other spots I thought it helped clarity. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94341/new/

https://reviews.llvm.org/D94341