[PATCH] D93764: [LoopUnswitch] Implement first version of partial unswitching.
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 11 10:59:08 PST 2021
jdoerfert added a comment.
Generally fine, I have one questions though
================
Comment at: llvm/lib/Transforms/Scalar/LoopUnswitch.cpp:710
+ continue;
+ auto SeenIns = Seen.insert(Current);
+ if (!SeenIns.second)
----------------
Nit: `const auto &`
================
Comment at: llvm/lib/Transforms/Scalar/LoopUnswitch.cpp:742
+ for (Use &U : Current->uses())
+ AccessesToCheck.push_back(cast<MemoryAccess>(U.getUser()));
+ }
----------------
Why do we need to check these uses?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93764/new/
https://reviews.llvm.org/D93764
More information about the llvm-commits
mailing list