[PATCH] D93912: [libc++][P1679] add string contains

[Wim Leflere via Phabricator via llvm-commits]

WimLeflere added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.contains/contains.char.pass.cpp:21
+{
+    using S = std::string;
+
----------------
curdeius wrote:
> curdeius wrote:
> > You cannot just use std::string as it's not constexpr-friendly (yet), but need to use a constexpr-loving allocator or do some other hacks.
> Actually, I think we just need to comment out constexpr test and add a FIXME note.
I could add a `#ifdef __cpp_lib_constexpr_string` error message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912