[PATCH] D93659: [AIX][XCOFF] emit vector info of traceback table.
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 11 10:26:13 PST 2021
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2006
+ // VR is saved on the stack.
+ VRData |= TracebackTable::IsVRSavedOnStackMask;
+ break;
----------------
DiggerLin wrote:
> jasonliu wrote:
> > I think we are only supposed to set this bit when the special register VRSAVE is saved on stack.
> Hubert point out that XL sets the bit (at least when there are other vector registers saved) , maybe we need double confirm with hubert @hubert.reinterpretcast
You're both right. XL sets the bit (I don't think it was supposed to). The funny thing is that setting the bit prevents a possible misinterpretation of the traceback table by the XL C++ runtime because of a confluence of errors.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93659/new/
https://reviews.llvm.org/D93659
More information about the llvm-commits
mailing list