[PATCH] D94389: [InlineSpiller] Add an assert for untied registers

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

I would strongly prefer that instead of simply asserting that we retie the registers.  Doing so should be fairly simple - we just need to keep track of which register pairs we untied for the possible fold, and use a lambda to retie them.

Despite that, I am also LGTMing this as an interim step.

Context for those reading along, there's some form of register allocator related miscompile happening in a complicated statepoint example.  This bit of code came up in an audit for possible issues - thus the desire to rule it out with asserts.  Reducing the example down to a small enough test case to analyze has been challenging.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94389/new/

https://reviews.llvm.org/D94389