[PATCH] D94354: [ELF] Drop .rel[a].debug_gnu_pub{names,types} for --gdb-index --emit-relocs
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 11 09:23:58 PST 2021
MaskRay added inline comments.
================
Comment at: lld/test/ELF/gdb-index.s:51
-# SECTION-NOT: debug_gnu_pubnames
+# SECTION-NOT: .debug_gnu_pubnames
+# SECTION-NOT: .debug_gnu_pubtypes
----------------
grimar wrote:
> Perhaps, just
>
> ```
> SECTION-NOT: .debug_gnu_pub
> ```
>
> And move the comment from above here to clarify that this line checks we
> don't emit `.debug_gnu_pubnames`, `.debug_gnu_pubtypes` and their relocation sections if --emit-relocs is specified.
Having both is probably clearer. Moved.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94354/new/
https://reviews.llvm.org/D94354
More information about the llvm-commits
mailing list