[PATCH] D94354: [ELF] Drop .rel[a].debug_gnu_pub{names,types} for --gdb-index --emit-relocs

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:2889
+        if (!rel->isLive())
+          return true;
+    return !s->isLive();
----------------
MaskRay wrote:
> grimar wrote:
> > ```
> > if (InputSectionBase *rel = isec->getRelocatedSection())
> >   return !rel->isLive();
> > ```
> ```
> if (!rel->isLive())
>    return true;
> ```
> is deliberate.
> 
> The suggested version is less reliable: if .debug_pubnames erroneously relocates other sections, it may still trigger a crash...
> 
nvm. it is not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94354/new/

https://reviews.llvm.org/D94354