[PATCH] D94387: Add new LLVMComponents CMake module.

Stella Laurenzo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 08:38:04 PST 2021


stellaraccident added inline comments.


================
Comment at: llvm/cmake/modules/LLVMComponents.cmake:16
+# Consumers link to a component in one of two ways:
+#   a) With a special `llvm-component::` namespace prefixed to the component
+#      name in target_link_libraries (or LINK_LIBS if using an llvm_add_library
----------------
Note: it took several iterations on the codebase to get it to the point where the component interface target has the component name (there were a number of conflicting usages), but now that it does, I can remove this alias, in favor of just directly linking against the component name (ie. LLVMSupport). I'll remove the alias in a follow-up (it is rather delicate to keep the codebase building as I change things here).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94387/new/

https://reviews.llvm.org/D94387



More information about the llvm-commits mailing list