[PATCH] D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner

Yvan Roux via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 08:12:13 PST 2021


yroux added a comment.

One small comment otherwise LGTM



================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:515
+  SetVector<Value *> OverallInputs, PremappedInputs, SinkCands, HoistCands,
+      DummyOutputs;
 
----------------
Maybe adding a small description in the comment above to explain why these outputs are not needed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94303/new/

https://reviews.llvm.org/D94303



More information about the llvm-commits mailing list