[PATCH] D94228: [flang][driver] Support fixed form detection

[Faris via Phabricator via llvm-commits]

FarisRehman marked 2 inline comments as done.
FarisRehman added inline comments.


================
Comment at: flang/lib/Frontend/FrontendOptions.cpp:21
           Language::Fortran)
+      .Cases("ff", "FOR", "for", "f77", "ff90", "fpp", "FPP", Language::Fortran)
       .Default(Language::Unknown);
----------------
sameeranjoshi wrote:
> Why is this repeated from above `Cases` statement?
> Why are all options not inside a single `Cases` statement?
> If it's an issue mentioned from the comments, would it be better to differentiate the above options in 2 different `Cases` based on free and fixed form and add a one liner comment on top about the form they belong to?
Correct, it is because of the issue mentioned in the comments.
I agree and I have made the changes to separate the cases based on form, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94228/new/

https://reviews.llvm.org/D94228