[PATCH] D94416: [PM] Avoid duplicates in the Used/Preserved/Required sets

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope created this revision.
Herald added subscribers: dexonsmith, hiraditya.
bjope requested review of this revision.
Herald added a project: LLVM.

The pass analysis uses "sets" implemented using a SmallVector type
to keep track of Used, Preserved, Required and RequiredTransitive
passes. When having nested analyses we could end up with duplicates
in those sets, as there was no checks to see if a pass already
existed in the "set" before pushing to the vectors. This idea with
this patch is to avoid such duplicates by avoiding pushing elements
that already is contained when adding elements to those sets.

To align with the above PMDataManager::collectRequiredAndUsedAnalyses
is changed to skip adding both the Required and RequiredTransitive
passes to its result vectors (since RequiredTransitive always is
a subset of Required we ended up with duplicates when traversing
both sets).

Main goal with this is to avoid spending time verifying the same
analysis mulitple times in PMDataManager::verifyPreservedAnalysis
when iterating over the Preserved "set". It is assumed that removing
duplicates from a "set" shouldn't have any other negative impact
(I have not seen any problems so far). If this ends up causing
problems one could do some uniqueness filtering of the vector being
traversed in verifyPreservedAnalysis instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94416

Files:
  llvm/include/llvm/PassAnalysisSupport.h
  llvm/lib/IR/LegacyPassManager.cpp
  llvm/lib/IR/Pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94416.315801.patch
Type: text/x-patch
Size: 3496 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210111/03478960/attachment.bin>