[PATCH] D94415: Fix minor build issue (NFC)
David Stuttard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 11 07:13:04 PST 2021
dstuttard created this revision.
Herald added subscribers: pengfei, hiraditya, qcolombet.
dstuttard requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Change [x86] Fix tile register spill issue was causing problems for our build
using gcc-5.4.1
The problem was caused by this line:
for (const MachineInstr &MI : make_range(MIS.begin(), MI))
where MI was previously defined as a MachineBasicBlock iterator.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D94415
Files:
llvm/lib/CodeGen/InlineSpiller.cpp
Index: llvm/lib/CodeGen/InlineSpiller.cpp
===================================================================
--- llvm/lib/CodeGen/InlineSpiller.cpp
+++ llvm/lib/CodeGen/InlineSpiller.cpp
@@ -1553,12 +1553,12 @@
for (auto const &Insert : SpillsToIns) {
MachineBasicBlock *BB = Insert.first;
Register LiveReg = Insert.second;
- MachineBasicBlock::iterator MI = IPA.getLastInsertPointIter(OrigLI, *BB);
- MachineInstrSpan MIS(MI, BB);
- TII.storeRegToStackSlot(*BB, MI, LiveReg, false, Slot,
+ MachineBasicBlock::iterator MII = IPA.getLastInsertPointIter(OrigLI, *BB);
+ MachineInstrSpan MIS(MII, BB);
+ TII.storeRegToStackSlot(*BB, MII, LiveReg, false, Slot,
MRI.getRegClass(LiveReg), &TRI);
- LIS.InsertMachineInstrRangeInMaps(MIS.begin(), MI);
- for (const MachineInstr &MI : make_range(MIS.begin(), MI))
+ LIS.InsertMachineInstrRangeInMaps(MIS.begin(), MII);
+ for (const MachineInstr &MI : make_range(MIS.begin(), MII))
getVDefInterval(MI, LIS);
++NumSpills;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94415.315800.patch
Type: text/x-patch
Size: 1085 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210111/f41659bf/attachment.bin>
More information about the llvm-commits
mailing list