[PATCH] D94102: [AMDGPU] Deduplicate VOP tablegen asm & ins
Dmitry Preobrazhensky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 11 06:50:12 PST 2021
dp accepted this revision.
dp added a comment.
This revision is now accepted and ready to land.
LGTM except for minor notes. Very nice simplification, thanks!
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:1673
+ dag opsel = (ins op_sel0:$op_sel);
+ dag 3pFields = (ins op_sel_hi0:$op_sel_hi, neg_lo0:$neg_lo, neg_hi0:$neg_hi);
+ dag ret = !con(base,
----------------
Maybe vop3pFields would be more clear
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:1731
+ HasModifiers, Src0Mod, Src1Mod>.ret,
+ (ins dpp_ctrl:$dpp_ctrl, row_mask:$row_mask,
+ bank_mask:$bank_mask, bound_ctrl:$bound_ctrl));
----------------
misleading margin
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:1748
+ HasModifiers, Src0Mod, Src1Mod>.ret,
+ (ins dpp8:$dpp8, FI:$fi));
}
----------------
misleading margin
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:1914
+class getAsmDPP8 <bit HasDst, int NumSrcArgs, bit HasModifiers, ValueType DstVT = i32>
+ : getAsmDPP<HasDst, NumSrcArgs, HasModifiers, DstVT>{
+ let ret = dst#args#" $dpp8$fi";
----------------
Missing space
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94102/new/
https://reviews.llvm.org/D94102
More information about the llvm-commits
mailing list