[PATCH] D94406: [AMDGPU] Fix failing assert with scratch ST mode

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 06:31:52 PST 2021


sebastian-ne updated this revision to Diff 315791.
sebastian-ne added a comment.

Your formulation is definitely better.

>From what I see, that change should be fine with other targets.
PowerPC asserts that `BaseOps.size() == 1`, which is fine as there is always exactly one operand if getMemOperandsWithOffsetWidth returns true there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94406/new/

https://reviews.llvm.org/D94406

Files:
  llvm/include/llvm/CodeGen/TargetInstrInfo.h
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
  llvm/test/CodeGen/AMDGPU/memory_clause.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94406.315791.patch
Type: text/x-patch
Size: 16042 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210111/873c7bf2/attachment.bin>


More information about the llvm-commits mailing list