[PATCH] D94406: [AMDGPU] Fix failing assert with scratch ST mode

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne updated this revision to Diff 315784.
sebastian-ne added a comment.

> I think the intention was that getMemOperandsWithOffsetWidth should return false if no base operands were found (perhaps MachineScheduler could assert this?)

I’d argue that in this case, we found the base operands and we know that except for the constant offset, they are zero.
Also, we want these operations to be claused, I think this is the likely case for stack accesses in entry-points.

Should we adjust the documentation comment to something like this?

> It returns false if no base operands and offset was found.

→ It returns false if no base operands and offset could be determined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94406/new/

https://reviews.llvm.org/D94406

Files:
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
  llvm/test/CodeGen/AMDGPU/memory_clause.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94406.315784.patch
Type: text/x-patch
Size: 15027 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210111/7126ba0f/attachment.bin>