[PATCH] D94074: [AArch64][SVE] Remove chains of unnecessary SVE reinterpret intrinsics

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsic-opts-reinterpret.ll:84
+; work as the first two.
+define <vscale x 4 x i1> @reinterpret_test_partial_chain(<vscale x 2 x i1> %a) {
+; OPT-LABEL: @reinterpret_test_partial_chain(
----------------
david-arm wrote:
> If you create a test with similar to this, but with "<vscale x 2 x i1> %a" is there a bug? From your algorithm above it looks like EarliestRemoval would be "%2 tail call ...", but we'd keep iterating Cursor until we get to "%a". If I've understood your algorithm correctly won't that mean we end up deleting %1 and %2 and end up with this?
> 
> define <vscale x 4 x i1> @reinterpret_test_partial_chain(<vscale x 8 x i1> %a) {
>   ret <vscale x 4 x i1> %2;
> }
> 
Sorry, I meant create a test similar to this, but with "<vscale x 8 x i1> %a"!!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94074/new/

https://reviews.llvm.org/D94074