[PATCH] D94323: [dsymutil] Add preliminary support for DWARF 5.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 04:58:46 PST 2021


avl added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinkerForBinary.h:163
 
+    uint64_t relocateIndexedAddr(uint64_t Addr) override;
+
----------------
nit: probably it would be better to name argument not Addr, but DebugAddrOffset or something like that. To make it clear that specified operand is not an address but offset in the debug_addr table.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94323/new/

https://reviews.llvm.org/D94323



More information about the llvm-commits mailing list