[PATCH] D93754: [obj2yaml] - Fix the crash in getUniquedSectionName().

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 03:49:16 PST 2021


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:128
+  unsigned SecIndex = &Sec - &Sections[0];
+  assert(&Sections[SecIndex] == &Sec);
   if (!SectionNames[SecIndex].empty())
----------------
jhenderson wrote:
> Seems to me like this assert is rather unnecessary? That's just saying that the previous line's calculation is correct.
Yeah. I'll remove it before committing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93754/new/

https://reviews.llvm.org/D93754



More information about the llvm-commits mailing list