[PATCH] D88466: [CSKY 1/n] Add basic stub or infra of csky backend

Mon Jan 11 00:27:20 PST 2021

zixuan-wu added inline comments.

================
Comment at: llvm/lib/Target/CSKY/TargetInfo/CSKYTargetInfo.cpp:18
+
+extern "C" void LLVMInitializeCSKYTargetInfo() {
+  RegisterTarget<Triple::csky> X(getTheCSKYTarget(), "csky", "C-SKY", "CSKY");
----------------
Arfrever wrote:
> This needs `LLVM_EXTERNAL_VISIBILITY`:
> 
> ```
> extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeCSKYTargetInfo() {
> ```
> 
> To avoid error:
> ```
> FAILED: lib/libLTO.so.12 
> : && /usr/bin/x86_64-pc-linux-gnu-g++ -m32 -fPIC -march=native -O2  -pipe -fPIC -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections  -fuse-ld=bfd -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,--gc-sections -Wl,--sort-common -Wl,-z,now -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/var/tmp/portage/sys-devel/llvm-12.0.0.9999/work/llvm_build-abi_x86_32.x86/./lib  -Wl,-O3 -Wl,--gc-sections  -Wl,--version-script,"/var/tmp/portage/sys-devel/llvm-12.0.0.9999/work/llvm_build-abi_x86_32.x86/tools/lto/LTO.exports" -shared -Wl,-soname,libLTO.so.12 -o lib/libLTO.so.12 tools/lto/CMakeFiles/LTO.dir/LTODisassembler.cpp.o tools/lto/CMakeFiles/LTO.dir/lto.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib"  lib/libLLVM-12git.so && :
> /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld.bfd: tools/lto/CMakeFiles/LTO.dir/lto.cpp.o: in function `lto_initialize()':
> lto.cpp:(.text._ZL14lto_initializev+0x7e): undefined reference to `LLVMInitializeCSKYTargetInfo'
> /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld.bfd: lto.cpp:(.text._ZL14lto_initializev+0xe2): undefined reference to `LLVMInitializeCSKYTargetInfo'
> /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld.bfd: tools/lto/CMakeFiles/LTO.dir/LTODisassembler.cpp.o: in function `lto_initialize_disassembler':
> LTODisassembler.cpp:(.text.lto_initialize_disassembler+0x49): undefined reference to `LLVMInitializeCSKYTargetInfo'
> collect2: error: ld returned 1 exit status
> ```
> This needs `LLVM_EXTERNAL_VISIBILITY`:
> 
> ```
> extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeCSKYTargetInfo() {
> ```
> 
> To avoid error:
> ```
> FAILED: lib/libLTO.so.12 
> : && /usr/bin/x86_64-pc-linux-gnu-g++ -m32 -fPIC -march=native -O2  -pipe -fPIC -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections  -fuse-ld=bfd -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,--gc-sections -Wl,--sort-common -Wl,-z,now -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/var/tmp/portage/sys-devel/llvm-12.0.0.9999/work/llvm_build-abi_x86_32.x86/./lib  -Wl,-O3 -Wl,--gc-sections  -Wl,--version-script,"/var/tmp/portage/sys-devel/llvm-12.0.0.9999/work/llvm_build-abi_x86_32.x86/tools/lto/LTO.exports" -shared -Wl,-soname,libLTO.so.12 -o lib/libLTO.so.12 tools/lto/CMakeFiles/LTO.dir/LTODisassembler.cpp.o tools/lto/CMakeFiles/LTO.dir/lto.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib"  lib/libLLVM-12git.so && :
> /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld.bfd: tools/lto/CMakeFiles/LTO.dir/lto.cpp.o: in function `lto_initialize()':
> lto.cpp:(.text._ZL14lto_initializev+0x7e): undefined reference to `LLVMInitializeCSKYTargetInfo'
> /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld.bfd: lto.cpp:(.text._ZL14lto_initializev+0xe2): undefined reference to `LLVMInitializeCSKYTargetInfo'
> /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld.bfd: tools/lto/CMakeFiles/LTO.dir/LTODisassembler.cpp.o: in function `lto_initialize_disassembler':
> LTODisassembler.cpp:(.text.lto_initialize_disassembler+0x49): undefined reference to `LLVMInitializeCSKYTargetInfo'
> collect2: error: ld returned 1 exit status
> ```

Sorry to miss the notify.
It's fixed at https://reviews.llvm.org/rGcddd3faf5debdfd2c09bb5b723f579fa8c8d5027.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88466/new/

https://reviews.llvm.org/D88466