[PATCH] D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/GOFF.h:109
+
+enum ESDExecutable {
+  ESD_EXE_Unspecified = 0,
----------------
yusra.syeda wrote:
> jhenderson wrote:
> > Is the field that holds this not a fixed size type? If it is, you could use `uint8_t`/`uin16_t` etc as appropriate here to match.
> This field is 3 bits in size. 
Right, okay. I'd still consider using `uint8_t`, as that is the smallest type that can be used here, I believe. Same probably applies elsewhere. This will allow easier print formatting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89071/new/

https://reviews.llvm.org/D89071