[PATCH] D94228: [flang][driver] Support fixed form detection

[sameeran joshi via Phabricator via llvm-commits]

sameeranjoshi requested changes to this revision.
sameeranjoshi added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/lib/Frontend/FrontendOptions.cpp:16
   return llvm::StringSwitch<InputKind>(extension)
-      // TODO: Should match the list in flang/test/lit.cfg.py
+      // Note: keep this list in-sync with flang/test/lit.cfg.py
+      // TODO: Add Cuda Fortan files (i.e. `*.cuf` and `*.CUF`).
----------------
What about `.f08` extension or maybe `f03`?
It seems to be in one of the popular compilers[1]

[1]https://github.com/llvm/llvm-project/blob/master/flang/docs/OptionComparison.md#notes


================
Comment at: flang/lib/Frontend/FrontendOptions.cpp:21
           Language::Fortran)
+      .Cases("ff", "FOR", "for", "f77", "ff90", "fpp", "FPP", Language::Fortran)
       .Default(Language::Unknown);
----------------
Why is this repeated from above `Cases` statement?
Why are all options not inside a single `Cases` statement?
If it's an issue mentioned from the comments, would it be better to differentiate the above options in 2 different `Cases` based on free and fixed form and add a one liner comment on top about the form they belong to?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94228/new/

https://reviews.llvm.org/D94228