[PATCH] D93497: Salvage debug info for function arguments in coro-split funclets.

Yifeng Dong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 10 21:42:44 PST 2021


dongAxis1944 added a comment.

I write a simple patch which might be work under O2 <https://reviews.llvm.org/owners/package/2/>, but because we will not have any dbg.declare under O2 <https://reviews.llvm.org/owners/package/2/> level, it might work in some locations. And I will submit it later

In D93497#2488109 <https://reviews.llvm.org/D93497#2488109>, @aprantl wrote:

>> Do you have any plan to salvage debug info under O2 <https://reviews.llvm.org/owners/package/2/> when most of the dbg.declare are changed to dbg.value?
>
> I was hoping that in an optimization pipeline the coroutine splitting would be invoked //before// mem2reg. This patch is really depending on the semantics of dbg.declare, which guarantees that the address of the variable doesn't change throughout the entire function. With a dbg.value we don't have any such guarantees, since it's just a snapshot at one particular location.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93497/new/

https://reviews.llvm.org/D93497



More information about the llvm-commits mailing list