[PATCH] D94248: [NFC][FuncAttrs] Add comment on why we look for noreturn calls

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

I'm dropping my request which triggered this review.  Feel free to close.

Why?  Because I went and looked into this further, and neither the old nor new pass manager actually handle this in a sane way.  With the recent changes, they both handle it in approximately the same insane way.

Both have a nice bottom up traversal of the call graph.  You think we'd simplify the SCC, then infer properties, than move to the caller SCC and exploit them right?  Well, no.  We infer, then simplify, then go to the caller.  The result is that we don't get to benefit from any of the simplification when doing the analysis.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94248/new/

https://reviews.llvm.org/D94248