[PATCH] D93974: [ValueTracking] Safe assumption context for args

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 10 14:21:41 PST 2021


jdoerfert added a comment.

FWIW, I agree with @nikic, we should not put this logic here. There are two problems:

1. We compute something we might not need.
2. We do it only in value tracking.

I'd prefer the following, though the `nullptr` proposal seems fine too:
a) For arguments use the first instruction in the entry as context, this is trivial and correct.
b) When the context is used, e.g., to look for assumption, allow to some exploration of surrounding instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93974/new/

https://reviews.llvm.org/D93974



More information about the llvm-commits mailing list