[PATCH] D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671)

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, one comment that should be addressed.



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:975
+__OMP_SCHED_TYPE(ORD_AUTO, 70)
+__OMP_SCHED_TYPE(SCH_DEFAULT, 34) // = SCH_STATIC
+/// dist_schedule types
----------------
I think you might be able to write 
`__OMP_SCHED_TYPE(SCH_DEFAULT, OMP_SCHED_TYPE_SCH_static)`
to avoid the comment.

Also, can we add the missing characters and call it ORDER, and SCHEDULE, or at least SCHED instead of SCH.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94373/new/

https://reviews.llvm.org/D94373