[PATCH] D94371: [lld/mac] Implement -u flag

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 10 06:19:55 PST 2021


thakis added inline comments.


================
Comment at: lld/test/MachO/u.s:22
+# UNDEF: error: undefined symbol: _asdf
+
+#--- foo.s
----------------
MaskRay wrote:
> Would be nice to check the interaction with `.weak_reference`
As far as I understand, `.weak_reference` only affects which opcodes are written to the import bind FSA description and doesn't interact with symbol lookup. Are you thinking of `-U` instead of `-u` maybe? Or do you mean a test that checks if a `-u` resolved against a dylib pulls in the dylib (independent of weak_ref)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94371/new/

https://reviews.llvm.org/D94371



More information about the llvm-commits mailing list