[PATCH] D94306: [LoopRotate] Use llvm.experimental.noalias.scope.decl for duplicating noalias metadata as needed

Jeroen Dobbelaere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 9 10:24:35 PST 2021


jeroen.dobbelaere marked 2 inline comments as done.
jeroen.dobbelaere added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopRotationUtils.cpp:503
+        // And move the original NAD to the NewHeader
+        NAD->moveBefore(NewHeaderInsertionPoint);
+      }
----------------
nikic wrote:
> Is there any reason to insert a new one before NAD and then move NAD, rather then just inserting the new one at NewHeaderInsertionPoint?
hmm. Probably not.. let me change this.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94306/new/

https://reviews.llvm.org/D94306



More information about the llvm-commits mailing list