[PATCH] D91678: Symbolizer test for Basic block sections

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram marked 3 inline comments as done.
tmsriram added inline comments.


================
Comment at: llvm/test/DebugInfo/llvm-symbolizer-bbsections-test.s:2
+# REQUIRES: x86-registered-target
+# RUN: clang -c %s -o %t
+# RUN: llvm-symbolizer --obj=%t 0x30 0x20 0x6c 0xf | FileCheck %s
----------------
MaskRay wrote:
> dblaikie wrote:
> > MaskRay wrote:
> > > Hmmm. `llvm/test` tests cannot use `clang` due to layering reason.
> > Oh, right, yeah - sorry I missed that. Like the other test I mentioned/others in this directory, you can use llvm-mc to assemble, rather than clang. (probably best to go check  llvm/test/DebugInfo/symbolize-paths.s by way of example)
> `llvm-mc -filetype=obj -triple=x86_64 %s -o %t`
> 
> Without `--target=` or `-target ` the default target triple is inferred from `LLVM_DEFAULT_TARGET_TRIPLE`. The object file may not be x86.
Sorry I missed this, just oversight. Thanks for spotting it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91678/new/

https://reviews.llvm.org/D91678