[PATCH] D94345: [SPARC] Fix fp128 load/stores

[LemonBoy via Phabricator via llvm-commits]

LemonBoy marked 3 inline comments as done.
LemonBoy added a comment.

> You can use "-stop-after=finalize-isel" and check the MIR output which should print the memory operands. I think maybe update_mir_test_checks.py can generate the check lines for MIR output from a .ll test.

That's perfect, the test is much better now.



================
Comment at: llvm/lib/Target/Sparc/SparcISelLowering.cpp:2734
   SDLoc dl(Op);
   LoadSDNode *LdNode = dyn_cast<LoadSDNode>(Op.getNode());
   assert(LdNode && LdNode->getOffset().isUndef()
----------------
jrtc27 wrote:
> craig.topper wrote:
> > This dyn_cast is only checked by the assert below. The rest of the code just blindly dereferences it.
> If you're looking for code quality don't look at the SPARC backend... it does suffer somewhat from being the first ever backend (and not having a lot of people care about it these days to clean it up).
Turned that into a asserting `cast<>`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94345/new/

https://reviews.llvm.org/D94345