[PATCH] D94040: [WebAssembly] Update basic EH instructions for the new spec

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrControl.td:154
+               [(set I32:$dst,
+                 (WebAssemblycatch (WebAssemblywrapper texternalsym:$tag)))],
+               "catch   \t$dst, $tag", "catch   \t$tag", 0x07>;
----------------
tlively wrote:
> This isn't totally related to this diff, but do you remember why `WebAssemblywrapper` exists? I don't think I ever had a good grasp on why we need it.
I don't know well either. I think it was added before I started working on the codebase. I thought it was supposed to serve as a wrapper for a symbol or an address, but I'm not sure if we can use those symbol or global address nodes directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94040/new/

https://reviews.llvm.org/D94040