[PATCH] D91678: Symbolizer test for Basic block sections

Fri Jan 8 16:10:09 PST 2021

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good, thanks!

================
Comment at: llvm/test/DebugInfo/symbolize-bbsections.test:1
+RUN: clang -c %p/Inputs/llvm-symbolizer-bbsections-test.s -o %t
+RUN: llvm-symbolizer --obj=%t 0x30 0x20 0x6c 0xf | FileCheck %s
----------------
Could you collapse the .test file and .s file? (move the contents of the .s file to the .test file, change the .test extension to .s - use assembly comments for all the RUN and CHECK lines) - would make it easier to read everything about the test in one file.

See llvm/test/DebugInfo/symbolize-paths.s for an example of this.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91678/new/

https://reviews.llvm.org/D91678