[PATCH] D94345: [SPARC] Fix fp128 load/stores

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/Sparc/SparcISelLowering.cpp:2734
   SDLoc dl(Op);
   LoadSDNode *LdNode = dyn_cast<LoadSDNode>(Op.getNode());
   assert(LdNode && LdNode->getOffset().isUndef()
----------------
craig.topper wrote:
> This dyn_cast is only checked by the assert below. The rest of the code just blindly dereferences it.
If you're looking for code quality don't look at the SPARC backend... it does suffer somewhat from being the first ever backend (and not having a lot of people care about it these days to clean it up).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94345/new/

https://reviews.llvm.org/D94345