[PATCH] D94334: [InlineAdvisor] Allow replay of inline decisions for the CGSCC inliner from optimization remarks

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 14:17:09 PST 2021


wenlei added inline comments.


================
Comment at: llvm/lib/Analysis/ReplayInlineAdvisor.cpp:58
+namespace {
+class ReplayInlineAdvice : public InlineAdvice {
+public:
----------------
This looks redundant/similar to `DefaultInlineAdvice`, is that just for controlling `EmitRemarks`? ORE should be able to handle remark printing (or not) correctly without extra guard. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94334/new/

https://reviews.llvm.org/D94334



More information about the llvm-commits mailing list