[PATCH] D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format

Yusra Syeda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 13:43:33 PST 2021


yusra.syeda marked an inline comment as done.
yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/GOFF.h:109
+
+enum ESDExecutable {
+  ESD_EXE_Unspecified = 0,
----------------
jhenderson wrote:
> Is the field that holds this not a fixed size type? If it is, you could use `uint8_t`/`uin16_t` etc as appropriate here to match.
This field is 3 bits in size. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89071/new/

https://reviews.llvm.org/D89071



More information about the llvm-commits mailing list