[PATCH] D93040: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/IR/Metadata.h:1216
+    return StringRef();
+  }
 };
----------------
This should probably be part of D92887 rather than this one.


================
Comment at: llvm/include/llvm/Transforms/Utils/Cloning.h:294
+};
+} // end namespace llvm
 #endif // LLVM_TRANSFORMS_UTILS_CLONING_H
----------------
Is this needed? I originally introduced this class in order to reuse it between inlining and unrolling, but as far as I can tell, you do not make use of it later in the patch series (D92887 implements a separate set of helper functions). If that's right, then I would simply drop these changes and keep the original code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93040/new/

https://reviews.llvm.org/D93040